Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variable: small cleanups #25266

Merged
merged 8 commits into from
Jun 11, 2021
Merged

variable: small cleanups #25266

merged 8 commits into from
Jun 11, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Jun 8, 2021

What problem does this PR solve?

Problem Summary:

This is a small cleanup following the merge of #24914 - and then the removal of this from tidb-tests.

I have also changed the default "socket"; it gets overwritten during TiDB startup, but by changing it to empty string we can use it to auto-generate docs.

What is changed and how it works?

What's Changed:

Minor cleanup

Related changes

  • None

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • None

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2021
@morgo
Copy link
Contributor Author

morgo commented Jun 8, 2021

/run-check_dev_2

@morgo morgo added the sig/sql-infra SIG: SQL Infra label Jun 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2021
jackysp
jackysp approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2021
@jackysp
Copy link
Member

jackysp commented Jun 9, 2021

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2021
@morgo
Copy link
Contributor Author

morgo commented Jun 9, 2021

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 9, 2021
@morgo
Copy link
Contributor Author

morgo commented Jun 9, 2021

It looks like there is still code in tidb-test that tries to enable the option that this PR removes. I'll take a look tomorrow.

@morgo
Copy link
Contributor Author

morgo commented Jun 10, 2021

/run-all-tests --tidb-test=pr/1216

@morgo
Copy link
Contributor Author

morgo commented Jun 10, 2021

/run-all-tests --tidb-test=pr/1216

@morgo
Copy link
Contributor Author

morgo commented Jun 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fdbdccd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@morgo
Copy link
Contributor Author

morgo commented Jun 11, 2021

/run-integration-common-test

@ti-chi-bot
Copy link
Member

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a45b3aa into pingcap:master Jun 11, 2021
@morgo morgo deleted the cleanup-sysvars branch June 11, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @ti-chi-bot @jackysp @wjhuang2016